Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support generate react component #4

Merged
merged 7 commits into from
Jun 24, 2024
Merged

feat: support generate react component #4

merged 7 commits into from
Jun 24, 2024

Conversation

chouchouji
Copy link
Member

No description provided.

@chouchouji chouchouji force-pushed the feat-support-react branch from e830b5b to e5cc29e Compare June 18, 2024 23:02
haoziqaq
haoziqaq reviewed Jun 19, 2024
View reviewed changes
Copy link
Member

@haoziqaq haoziqaq left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

另外建议把不同框架的处理逻辑独立成单独的文件。单独做一个 framework 文件夹, utils/compiler 也放到 framework/vue3.ts 里

packages/varlet-icon-builder/src/commands/generate.ts Outdated Show resolved Hide resolved
packages/varlet-icon-builder/src/commands/generate.ts Outdated Show resolved Hide resolved
@chouchouji
Copy link
Member Author

另外建议把不同框架的处理逻辑独立成单独的文件。单独做一个 framework 文件夹, utils/compiler 也放到 framework/vue3.ts 里

好的

@chouchouji
Copy link
Member Author

@haoziqaq
image
这个感觉可以改成 enum

@chouchouji chouchouji changed the title feat: add generate tsx function feat: support generate react component Jun 19, 2024
@chouchouji
Copy link
Member Author

chouchouji commented Jun 19, 2024 •
edited
Loading

另外建议把不同框架的处理逻辑独立成单独的文件。单独做一个 framework 文件夹, utils/compiler 也放到 framework/vue3.ts 里

晚上再改下，还差把compile移进 vue3 里

@haoziqaq
Copy link
Member

@haoziqaq image 这个感觉可以改成 enum

其实不太需要 enum，主要的模块 format 就只有 cjs 和 esm 了。

@haoziqaq haoziqaq merged commit 103e9c2 into varletjs:main Jun 24, 2024
@chouchouji chouchouji deleted the feat-support-react branch June 24, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haoziqaq haoziqaq haoziqaq approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chouchouji @haoziqaq